Repository navigation
test(mcp-server): await the edit in the H2 approval test - #46
Merged
Merged
Conversation
The test fired the edit without awaiting it, so on a loaded runner the client's retry could reach the server before the edit was written: the publish then succeeded and the test failed (main, run after #44). The answer handler now awaits the edit, which is the scenario the test describes. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
Madraka
enabled auto-merge
October 21, 2026 11:43
Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Madraka <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test that failed CI on
mainafter #44:voids an elicited approval when the site changed after the question (H2)fired the page edit without awaiting it, so under load the retry could beat the edit and the publish succeeded. The answer handler may now be async, and the test awaits the edit before approving. 5/5 local runs green. No product code changed.🤖 Generated with Claude Code